Improve link detection and discard false positives

cerebral / addressbar

Makes the addressbar of the browser work just like a normal input

MIT License

84 stars 8 forks source link

Improve link detection and discard false positives #1

Closed garth closed 9 years ago

garth commented 9 years ago

Check if click was on child node
Discard clicks on mailto, target, modifier, external, download
Support touch
Allow other origin clicks

Logic derived from page.js

christianalfoni commented 9 years ago

eyh @garth, this is awesome, thanks for the pull :-)

garth commented 9 years ago

With this change, my app is back to where it was before moving to url-mapper/addressbar. In fact it's better, because sometimes with page I'd get into an infinite routing loop, which doesn't happen now.

christianalfoni commented 9 years ago

Awesome, yeah, great! Jup, this should work better because now it works like anything else in React. This is really great, thanks again for the pull @garth!