fix: replace node EventEmitter with EventEmitter3

cerebral / addressbar

Makes the addressbar of the browser work just like a normal input

MIT License

84 stars 8 forks source link

fix: replace node EventEmitter with EventEmitter3 #17

Closed henri-hulski closed 7 years ago

henri-hulski commented 7 years ago

Fixes cerebral/cerebral#389.

Guria commented 7 years ago

Test failed unfortunately :(

henri-hulski commented 7 years ago

@Guria 2 tests are failing :

'should not allow going to a new url'
'should handle trailing slash convertion'

I tried to look into it, but really no idea, why these 2 are failing and the others are passing.

Maybe you can have a look.

henri-hulski commented 7 years ago

The test error outputs are not very helpful. They even don't show the actual value of the assertions.

christianalfoni commented 7 years ago

So much for "drop in replacement" as stated on their repo ;-)

Does this problem happen every time? It is not a race condition that just happened to work on last test run?

christianalfoni commented 7 years ago

Yeah, now suddenly one of them ran green. It seems to be race condition not related to event emitter. Have to investigate this locally I think... I have my hands full with tutorial right now, can look into it tomorrow I think

Guria commented 7 years ago

Ahh forgot about this issue with addressbar. Restarted a test. I had a plans on addressbar refactoring :)

Guria commented 7 years ago

Have to restart it about 5 times :)