Closed LarsFlieger closed 2 years ago
I highly appreciate this, so simple yet so useful, this saved my day!!!
Looks good to me. Would you be able to add a test to prevent regression?
Thank you! I'm going to add them as soon as I got time. :)
@LarsFlieger Are you still planning to add the test? If not I would merge it as it is.
@LarsFlieger Are you still planning to add the test? If not I would merge it as it is.
I'm currently very busy. I'll come back to this when I got time. So feel free to merge it :)
Ok. Done!
You can get it by installing overmind-react@next
. 😊
thanks for the fix @LarsFlieger and @henri-hulski for merging 👍 Just run into this issue, so perfect timing
@henri-hulski seems like this didn't get published as overmind-react@next
. The last published version on next
channel was: https://www.npmjs.com/package/overmind-react/v/29.0.1-1624784835264 few months ago
https://app.travis-ci.com/github/cerebral/overmind/builds/246438851#L4463
ERR! publish Failed PUT 401\n\nnpm \nERR! code E401\n\nnpm ERR! This operation requires a one-time password from your authenticator
seems like a new "automation" NPM access token needs to be added to CI
@henri-hulski is it possible to update the CI token, or manually publish this fix?
I think @anna-bucher is in contact with @christianalfoni to change the access rights. After I will be able to publish. For updates follow the #random channel on Discord.
There is a bug while working in the development mode when components unmount:
Minimum reproduction code: https://github.com/dopeshot/ionic-overmind-cant-perform-state-update
How to reproduce:
Video of the issue: https://www.youtube.com/watch?v=5w6r1_lxoS8
StackOverflow discussion: https://stackoverflow.com/questions/70744871/ionic-react-overmind-cant-perform-a-react-state-update-on-an-unmounted-componen