Add style loader when CSS loader is used

cerebral / webpack-sandbox

A service that takes code and DLL manifests and produces a server side bundling process

10 stars 8 forks source link

Add style loader when CSS loader is used #3

Closed NMinhNguyen closed 7 years ago

NMinhNguyen commented 7 years ago

I've taken the version of style-loader that's in package.json. Without this change, the project ZIP isn't runnable when you're importing CSS files - it complains about the lack of style-loader, and I can see in the codebase that whenever the css-loader is used, you also add style-loader, so I think this was the right place to modify 😅

christianalfoni commented 7 years ago

Ah, yes! Thanks man :)

christianalfoni commented 7 years ago

I have deployed new version now, sorry for the delay. In paternity leave, so have not had much time lately!

NMinhNguyen commented 7 years ago

Ah thanks! No worries at all - I'm running a privately hosted version of this anyway, so I'd already made the change myself, but thought I'd contribute it back/run it by you to see if there's any issues. Oh and congrats :)