The source for the flappy tests turned out to be a missing default sort for requests through the relationship routes. This fixes that.
Removes tests that rely on comparing generated sql strings. The generated sql from the latest rails versions has changed due to new aliasing in the latest rails versions. This was making maintaining the tests very cumbersome.
Adds quotes around fields in the generated SQL fragments. Adds helper methods to create the sql for aliased fields.
Fixes #1358
All Submissions:
[ ] I've checked to ensure there aren't other open Pull Requests for the same update/change.
[ ] I've submitted a ticket for my issue if one did not already exist.
[ ] My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
[ ] I've used Github auto-closing keywords in the commit message or the description.
[ ] I've added/updated tests for this change.
New Feature Submissions:
[ ] I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
[ ] My submission includes new tests.
[ ] My submission maintains compliance with JSON:API.
Bug fixes and Changes to Core Features:
[ ] I've included an explanation of what the changes do and why I'd like you to include them.
[ ] I've provided test(s) that fails without the change.
Test Plan:
Reviewer Checklist:
[ ] Maintains compliance with JSON:API
[ ] Adequate test coverage exists to prevent regressions
The source for the flappy tests turned out to be a missing default sort for requests through the relationship routes. This fixes that.
Removes tests that rely on comparing generated sql strings. The generated sql from the latest rails versions has changed due to new aliasing in the latest rails versions. This was making maintaining the tests very cumbersome.
Adds quotes around fields in the generated SQL fragments. Adds helper methods to create the sql for aliased fields.
Fixes #1358
All Submissions:
New Feature Submissions:
Bug fixes and Changes to Core Features:
Test Plan:
Reviewer Checklist: