Fix sql quoting 0.10 - Githubissues

cerebris / jsonapi-resources

A resource-focused Rails library for developing JSON:API compliant servers.

http://jsonapi-resources.com

MIT License

2.32k stars 533 forks source link

Fix sql quoting 0.10 #1367

Closed lgebhardt closed 3 years ago

lgebhardt commented 3 years ago

Add quoting for fields in built up sql
Remove tests for generated sql statements

These are changing with new rails versions and it's creating a lot of false failures

Remove tests for generated sql statements using joins_left
Fix default sort for when empty array is provided

Fixes issue with relationship requests not getting a default sort

Add helper methods for generating sql fields with aliases and quotes

(cherry picked from commit 695bb7cb51cec2fb54dfb8032d0e07ea1d577c51)

All Submissions:

[ ] I've checked to ensure there aren't other open Pull Requests for the same update/change.
[ ] I've submitted a ticket for my issue if one did not already exist.
[ ] My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
[ ] I've used Github auto-closing keywords in the commit message or the description.
[ ] I've added/updated tests for this change.

New Feature Submissions:

[ ] I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
[ ] My submission includes new tests.
[ ] My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

[ ] I've included an explanation of what the changes do and why I'd like you to include them.
[ ] I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

[ ] Maintains compliance with JSON:API
[ ] Adequate test coverage exists to prevent regressions

lgebhardt commented 3 years ago

Tests are still flappy, though they can all complete with these changes.