fix: Reliably quote columns/tables

cerebris / jsonapi-resources

A resource-focused Rails library for developing JSON:API compliant servers.

http://jsonapi-resources.com

MIT License

2.32k stars 533 forks source link

fix: Reliably quote columns/tables #1400

Closed bf4 closed 1 year ago

bf4 commented 1 year ago

see https://github.com/rails/rails/blob/7-0-stable/activerecord/lib/active_record/connection_adapters/abstract/quoting.rb#L8-L146

Addresses https://github.com/cerebris/jsonapi-resources/issues/1369

bf4 commented 1 year ago

Not sure what the current failure means. Work so far is an improvement, I think.. not sure what to do next

bf4 commented 1 year ago

@lgebhardt I decided to merge this since the target is a dev branch and this meets the goals I set re: quoting and now it can be the basis for further work

lgebhardt commented 1 year ago

@bf4 sounds good to me. I'm not sure how to best handle the adapter based sorting differences, but we can definitely handle that in a separate pr.