restricting default railties version to be < 7 - Githubissues

cerebris / jsonapi-resources

A resource-focused Rails library for developing JSON:API compliant servers.

http://jsonapi-resources.com

MIT License

2.32k stars 532 forks source link

restricting default railties version to be < 7 #1416

Closed Kallin closed 1 year ago

Kallin commented 1 year ago

Resolves https://github.com/cerebris/jsonapi-resources/issues/1415

All Submissions:

[X ] I've checked to ensure there aren't other open Pull Requests for the same update/change.
[ X] I've submitted a ticket for my issue if one did not already exist.
[ X] My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
[ X] I've used Github auto-closing keywords in the commit message or the description.
[X ] I've added/updated tests for this change.

Bug fixes and Changes to Core Features:

[X ] I've included an explanation of what the changes do and why I'd like you to include them.
[ X] I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

[ ] Maintains compliance with JSON:API
[ ] Adequate test coverage exists to prevent regressions

bf4 commented 1 year ago

Closing as OP intent is app development, which is happening on v0-11-dev and there's no intention to restrict development to Rails 6.