fix: more reliable check of module is included - Githubissues

cerebris / jsonapi-resources

A resource-focused Rails library for developing JSON:API compliant servers.

http://jsonapi-resources.com

MIT License

2.32k stars 532 forks source link

fix: more reliable check of module is included #1418

Closed bf4 closed 1 year ago

bf4 commented 1 year ago

target is https://github.com/cerebris/jsonapi-resources/pull/1411

handle gems like GraphQL which override include?

rake aborted!
ArgumentError: wrong number of arguments (given 1, expected 3)
gems/graphql-2.0.13/lib/graphql/schema/directive.rb:58:in `include?'

All Submissions:

[x] I've checked to ensure there aren't other open Pull Requests for the same update/change.
[ ] I've submitted a ticket for my issue if one did not already exist.
[ ] My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
[ ] I've used Github auto-closing keywords in the commit message or the description.
[ ] I've added/updated tests for this change.

New Feature Submissions:

[ ] I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
[ ] My submission includes new tests.
[ ] My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

[x] I've included an explanation of what the changes do and why I'd like you to include them.
[ ] I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

[ ] Maintains compliance with JSON:API
[ ] Adequate test coverage exists to prevent regressions

bf4 commented 1 year ago

@lgebhardt I'm not sure what's causing these test failure in this branch but not in the target branch. Any objection to merging this and resolving anything there which may or may not show up?