Polymorphic types override per relationship - Githubissues

cerebris / jsonapi-resources

A resource-focused Rails library for developing JSON:API compliant servers.

http://jsonapi-resources.com

MIT License

2.32k stars 532 forks source link

Polymorphic types override per relationship #1440

Closed lgebhardt closed 10 months ago

lgebhardt commented 10 months ago

Allow relationship to set the polymorphic types

Warn when eager loading is disabled, which results in not being able to detect the types.

All Submissions:

[ ] I've checked to ensure there aren't other open Pull Requests for the same update/change.
[ ] I've submitted a ticket for my issue if one did not already exist.
[ ] My submission passes all tests. (Please run the full test suite locally to cut down on noise from travis failures.)
[ ] I've used Github auto-closing keywords in the commit message or the description.
[ ] I've added/updated tests for this change.

New Feature Submissions:

[ ] I've submitted an issue that describes this feature, and received the go ahead from the maintainers.
[ ] My submission includes new tests.
[ ] My submission maintains compliance with JSON:API.

Bug fixes and Changes to Core Features:

[ ] I've included an explanation of what the changes do and why I'd like you to include them.
[ ] I've provided test(s) that fails without the change.

Test Plan:

Reviewer Checklist:

[ ] Maintains compliance with JSON:API
[ ] Adequate test coverage exists to prevent regressions