search

cerebro-iiitv / cerebro-web

Website for Cerebro
https://cerebro.iiitv.ac.in
20 stars 13 forks source link

Add corresponding image on each event page if it exists #66

Closed anshumanv closed 6 years ago

anshumanv commented 6 years ago

Can someone pull and check this locally? Having some weird issue of cerebro logo not loading in footer.

Monal5031 commented 6 years ago

screenshot from 2018-03-06 09-53-43

@anshumanv ?

anshumanv commented 6 years ago

This pull corresponds to event page which goes like /event/:id check on that

anshumanv commented 6 years ago

You don't even know what this PR corresponds to, for panel img follow up here - https://github.com/cerebro-iiitv/web-2018/pull/64

Monal5031 commented 6 years ago

And exactly my point to stop you from self-merging or pushing directly to main, otherwise I would've reviewed it that time.

anshumanv commented 6 years ago

Ah, good for you then.

Monal5031 commented 6 years ago

Also, since you know a lot more than me, it'd be really kind of you to fix the rest of the react bugs too. Namely #34 #55

anshumanv commented 6 years ago

And exactly my point to stop you from self-merging or pushing directly to main, otherwise I would've reviewed it that time.

That PR was closed hours ago, you could've pointed it out that time when it was merged, but you didn't cuz you didn't check it, and then you say I should ask for review, eh?

singhpratyush commented 6 years ago

No good though :sweat_smile: