search

cerebroapp / cerebro

🔵 Cerebro is an open-source launcher to improve your productivity and efficiency
https://www.cerebroapp.com/
MIT License
8.27k stars 454 forks source link

feat: migrate move file to native nodejs #597

Closed ogustavo-pereira closed 1 year ago

ogustavo-pereira commented 1 year ago

I'm removing the move-file dependency and changing it to native. I believe this package is no longer needed.

dubisdev commented 1 year ago

Hi @oguhpereira

I think move-file is more than a simple rename utility. It helps with creating recursive missing directories. We could migrate this to native but I think is a small dependency and does what we need.

https://bundlephobia.com/package/move-file@2.1.0 ➡️ Just 1.2kB

This PR is breaking scoped plugins installation

image

dubisdev commented 1 year ago

We could implement handling recursive directories (which is an additional work) or simply close this PR and continue using move-file

ogustavo-pereira commented 1 year ago

I have a negative question about the repository. It's not a very current repository, it hasn't been updated for a long time, I'm afraid it might hurt us for a moment.

I believe that if we are going to use it we should try to use at least the latest version, I tried here but it started to generate an error.

For the moment I will close the pr until I understand better how to proceed