search

ceres-solver / ceres-solver

A large scale non-linear optimization library
http://ceres-solver.org/
Other
3.66k stars 1.01k forks source link

2.2.0 online doc typo #1051

Closed linzha0 closed 3 months ago

linzha0 commented 3 months ago

Hi, I just realized there are some typos for 2.2.0 online document, for example hello world:

CostFunction* cost_function =
      new AutoDiffCostFunction<CostFunctor, 1, 1>();

However, the right one should be:

  CostFunction* cost_function =
      new AutoDiffCostFunction<CostFunctor, 1, 1>(new CostFunctor);

I installed version 2.2.0 on my Ubuntu 22.04 and built the document, it's right, just the online doc somehow is wrong.

sandwichmaker commented 3 months ago

The latest update to ceres eliminates the need to instantiate the functor.

On Wed, Feb 14, 2024 at 11:10 AM linzha0 @.***> wrote:

Hi, I just realized there are some typos for 2.2.0 online document, for example hello world http://ceres-solver.org/nnls_tutorial.html#hello-world:

CostFunction* cost_function = new AutoDiffCostFunction<CostFunctor, 1, 1>();

However, the right one should be:

CostFunction* cost_function = new AutoDiffCostFunction<CostFunctor, 1, 1>(new CostFunctor);

I installed version 2.2.0 on my Ubuntu 22.04 and built the document, it's right, just the online doc somehow is wrong.

— Reply to this email directly, view it on GitHub https://github.com/ceres-solver/ceres-solver/issues/1051, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANCABIMLI7E532I4MGCXKTYTUDZZAVCNFSM6AAAAABDI3X7I2VHI2DSMVQWIX3LMV43ASLTON2WKOZSGEZTKMBRGQZTMMI . You are receiving this because you are subscribed to this thread.Message ID: @.***>

linzha0 commented 3 months ago

thanks for the information.