search

ceres-solver / ceres-solver

A large scale non-linear optimization library
http://ceres-solver.org/
Other
3.75k stars 1.02k forks source link

Building ceres with BUILD_TESTING=OFF and BUILD_BENCHMARKS=ON #1081

Open whuaegeanse opened 4 weeks ago

whuaegeanse commented 4 weeks ago

Building ceres with BUILD_TESTING=OFF and BUILD_BENCHMARKS=ON will trigger compilation errors.

test_util in "target_link_libraries(${BENCHMARK_TARGET} PRIVATE test_util ceres_static benchmark::benchmark ${CERES_LIBRARY_PRIVATE_DEPENDENCIES})" should be removed.

sandwichmaker commented 3 weeks ago

Yes this is an artifact of a recent refactoring. Thanks for reporting it, I will fix it shortly.

On Fri, Jul 12, 2024, 11:20 AM WhuAegeanSea @.***> wrote:

Building ceres with BUILD_TESTING=OFF and BUILD_BENCHMARKS=ON will trigger compilation errors.

test_util in "target_link_libraries(${BENCHMARK_TARGET} PRIVATE test_util ceres_static benchmark::benchmark ${CERES_LIBRARY_PRIVATE_DEPENDENCIES}) https://github.com/ceres-solver/ceres-solver/blob/21b026aa2cbb91aa0691b8c71260b3bf65e71e96/internal/ceres/CMakeLists.txt#L554-L556" should be removed.

— Reply to this email directly, view it on GitHub https://github.com/ceres-solver/ceres-solver/issues/1081, or unsubscribe https://github.com/notifications/unsubscribe-auth/AANCABIWGDRJFHT6Q3QLULDZMANAVAVCNFSM6AAAAABKZMCDOCVHI2DSMVQWIX3LMV43ASLTON2WKOZSGQYDMMJSGM3TEOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

sandwichmaker commented 2 days ago

This is going to require some refactoring of test_util.h/cc.