search

ceres-solver / ceres-solver

A large scale non-linear optimization library
http://ceres-solver.org/
Other
3.86k stars 1.04k forks source link

Windows CI is broken. #808

Closed sandwichmaker closed 2 years ago

sandwichmaker commented 2 years ago

cc: @sergiud

sergiud commented 2 years ago

SuiteSparse on Windows is built without METIS whereas Ceres assumes METIS is available. Fixing the issue requires some adjustments of the CMake support for SuiteSparse as well as refactoring in Ceres directly since there's no METIS detection mechanism yet.

sandwichmaker commented 2 years ago

So for now just add a CERES_NO_METIS to the build? @alexsmac is planning on adding metis detection to the suitesparse cmake files.

sergiud commented 2 years ago

CERES_NO_METIS is an option, yes but not really necessary. METIS detection/availability indicator needs to be added to CMake SuiteSparse as well. Ideally, we synchronize to further ensure compatibility between FindSuiteSparse.cmake and CMake support for SuiteSparse.

I suggest adding a Partition component to find_package (SuiteSparse). Its presence will indicate whether CHOLMOD was compiled with METIS support.

sandwichmaker commented 2 years ago

Thats fair, my suggestion was only meant as a stop gap while FindSuiteSparse.cmake is modified.

sergiud commented 2 years ago

Ah yes. Sounds reasonable.