cereschen / vite-plugin-svg-sprite-component

7 stars 4 forks source link

Sourcemap is likely to be incorrect #9

Closed floydback closed 2 years ago

floydback commented 2 years ago

When I run yarn build with enabled sourcemap attribute I've get error:

Sourcemap is likely to be incorrect: a plugin (svg-sprite-component) was used to transform files, but didn't generate a sourcemap for the transformation. Consult the plugin documentation for help

cereschen commented 2 years ago

This may be the latest version of vite, but do we need the sourcemap of the svg files? But this tip is annoying. I'll consider doing it.

floydback commented 2 years ago

The problem is Vite doesn’t generate sources at all while using plugin svg sprite.

liho98 commented 2 years ago

Yup same issues, its throwing some error messages, it will causes my CI build failed. Feel free to check this out @cereschen Thanks in advance! image

cereschen commented 2 years ago

@liho98 I can't even reproduce this problem, but I have dealt with the sourmap problem, please update 1.0.9

liho98 commented 2 years ago

@liho98 I can't even reproduce this problem, but I have dealt with the sourmap problem, please update 1.0.9

Try with v1.0.9, the issue still persists, you may reproduce this error by enable the sourcemap when build.

// vite.config.js
    build: {
      sourcemap: true,
    },
cereschen commented 2 years ago

@liho98 I can't even reproduce this problem, but I have dealt with the sourmap problem, please update 1.0.9

Try with v1.0.9, the issue still persists, you may reproduce this error by enable the sourcemap when build.

// vite.config.js
    build: {
      sourcemap: true,
    },

You only need to upgrade 1.0.10. I have passed the test

liho00 commented 2 years ago

@liho98 I can't even reproduce this problem, but I have dealt with the sourmap problem, please update 1.0.9

Try with v1.0.9, the issue still persists, you may reproduce this error by enable the sourcemap when build.

// vite.config.js
    build: {
      sourcemap: true,
    },

You only need to upgrade 1.0.10. I have passed the test

yup tested, did not throwing the error messages already, thanks!