cerfacs-globc / icclim

icclim: Python library for climate indices and climate indicators calculation.
https://icclim.readthedocs.io/en/latest/
Apache License 2.0
81 stars 31 forks source link

Fix/rxxp tot total computation #283

Closed bzah closed 10 months ago

bzah commented 10 months ago

Pull Request to resolve #256

Describe the changes you made

When computing the total part of the rxxpTOT equation, we now properly convert the unit of the threshold min value before computing the total.

github-actions[bot] commented 10 months ago

Coverage

Report
FileStmtsMissCoverMissing
icclim
   icclim_exceptions.py7186%20
   icclim_logger.py852966%24, 43, 65, 70–95, 105, 111–142, 150–155
   main.py2782691%120, 129, 405, 490, 516–517, 519–520, 522, 524–525, 527–528, 547–554, 622–627, 708, 715, 719
   utils.py37586%22, 33–34, 36–37
icclim/ecad
   xclim_binding.py48688%39, 43, 68, 72, 97, 101
icclim/generic_indices
   generic_indicators.py4848582%57, 60, 77, 81, 85, 98, 104, 178, 218, 225, 359, 388, 680, 711, 717, 725, 745, 908, 913, 933–939, 943, 973, 975, 1040–1041, 1074–1101, 1128–1149, 1165, 1174–1175, 1201–1231, 1237–1241, 1265
   standard_variable.py48198%19
   threshold.py4022195%199, 219, 223, 271, 287–290, 305, 312, 388, 529, 598, 699, 902, 924, 930, 1004, 1007, 1106–1108
icclim/models
   cf_calendar.py35197%20
   climate_variable.py1001090%103, 162, 173, 207, 213, 251, 255, 283–284, 321
   frequency.py1761194%167–170, 314–316, 323, 401, 427, 432
   index_group.py34197%33
   operator.py29197%14
   standard_index.py28389%56, 59, 63
icclim/pre_processing
   input_parsing.py1953781%74, 78–79, 84, 103, 167, 172, 178, 187, 200, 229, 245, 259, 279, 287, 289, 298, 307, 325, 339–347, 356–373, 395
   rechunk.py86298%38, 132
TOTAL257124091% 

Test results

Tests Skipped Failures Errors Time
189 0 :zzz: 0 :x: 0 :fire: 1m 45s :stopwatch: