cern-fts / davix

High-performance file management over WebDAV / HTTP
GNU Lesser General Public License v2.1
84 stars 36 forks source link

Wrong format for downloaded files for release 0.8.4 #104

Closed ellert closed 1 year ago

ellert commented 1 year ago

The download link on the release page does not result in a file of the correct format. If I download:

$ wget https://github.com/cern-fts/davix/releases/download/R_0_8_4/davix-0.8.4.tar.gz

The retrieved file is a zip file, not a gzipped tar archive.

$ file davix-0.8.4.tar.gz davix-0.8.4.tar.gz: Zip archive data, at least v2.0 to extract, compression method=deflate

If I inflate this file

$ mkdir z $ cd z $ unzip ../davix-0.8.4.tar.gz Archive: ../davix-0.8.4.tar.gz inflating: davix-0.8.4.tar.gz
$ file davix-0.8.4.tar.gz davix-0.8.4.tar.gz: gzip compressed data, last modified: Thu Feb 2 11:17:28 2023, from Unix, original size modulo 2^32 36597760

I get the correct file. So the link give a zipped gzipped tar archive instead of a gzipped archive.

The corresponding link for the previous release gives the right format.

$ wget https://github.com/cern-fts/davix/releases/download/R_0_8_3/davix-0.8.3.tar.gz

$ file davix-0.8.3.tar.gz davix-0.8.3.tar.gz: gzip compressed data, last modified: Tue Sep 13 10:19:00 2022, from Unix, original size modulo 2^32 36587520

(The davix-0.8.4-el7.x86_64.tar.gz link also gives the wrong format.)

amadio commented 1 year ago

@joaopblopes This is blocking packaging of davix on several places (I also see a problem in Gentoo). Could you please upload the correct tarball replacing the zip file? Thanks!

joaopblopes commented 1 year ago

Hi @amadio ,

It should be in the right format now.

$ wget https://github.com/cern-fts/davix/releases/download/R_0_8_4/davix-0.8.4.tar.gz

$ file davix-0.8.4.tar.gz davix-0.8.4.tar.gz: gzip compressed data, last modified: Thu Feb 2 11:17:28 2023, from Unix, original size modulo 2^32 36597760

And:

$ wget https://github.com/cern-fts/davix/releases/download/R_0_8_4/davix-0.8.4-el7.x86_64.tar.gz

$ file davix-0.8.4-el7.x86_64.tar.gz davix-0.8.4-el7.x86_64.tar.gz: gzip compressed data, last modified: Thu Feb 2 11:22:22 2023, from Unix, original size modulo 2^32 7188480

amadio commented 1 year ago

Thanks! Now it works correclty, I am just seeing some bad warnings with GCC 12 which may warrant fixing for the next release:

 * QA Notice: Package triggers severe warnings which indicate that it
 *            may exhibit random runtime failures.
 * /tmp/portage/net-libs/davix-0.8.4/work/davix-0.8.4/deps/libneon/src/ne_openssl.c:1332:39: warning: the comparison will always evaluate as ‘false’ for the address of ‘thread_lock_neon’ will never be NULL [-Waddress]
 * /usr/lib/gcc/x86_64-pc-linux-gnu/12/include/g++-v12/bits/basic_string.h:234:28: warning: array subscript 0 is outside array bounds of ‘void [8]’ [-Warray-bounds]
 * /usr/lib/gcc/x86_64-pc-linux-gnu/12/include/g++-v12/bits/basic_string.h:1071:16: warning: array subscript 0 is outside array bounds of ‘void [8]’ [-Warray-bounds]
joaopblopes commented 1 year ago

Glad that it works now! Thanks for reporting this!

Regarding the warnings, I can have a look into them with Mihai. Maybe you can create a new issue to track it.

I'll close this issue here.

Cheers, João

chenrui333 commented 1 year ago

Thanks @joaopblopes!