cern-sis / issues-inspire

0 stars 0 forks source link

parse ORCIDs from APS #343

Closed michamos closed 1 year ago

michamos commented 1 year ago

APS now puts ORCIDs into their XML files. We should add their handling to the parser in hepcrawl so we add these ORCIDs to our records.

MJedr commented 1 year ago

@michamos can you please add a reference to the xml with orcid please?

michamos commented 1 year ago

Example: https://inspirehep.net/files/001ed07a15db98d367c548835954478e has

<contrib contrib-type="author">
        <contrib-id authenticated="true" contrib-id-type="orcid">
                https://orcid.org/0000-0003-1813-2645
        </contrib-id>
        <name>
                <surname>Hasenfratz</surname>
                <given-names>Anna</given-names>
        </name>
        <xref ref-type="aff" rid="a1">
                <sup>1</sup>
        </xref>
        <xref ref-type="author-notes" rid="n1">
                <sup>,*</sup>
        </xref>
</contrib>
MJedr commented 1 year ago

Tech notes In jats parser add a method to extract id from author node and add it there

drjova commented 1 year ago

@MJedr can we close this one?

MJedr commented 1 year ago

can we make sure it's working on prod as expected?

michamos commented 1 year ago

It's working: https://inspirehep.net/literature?sort=mostrecent&size=25&page=1&q=j%20phys.rev.%2A%20and%20authors.ids.schema%3AORCID edit: those were added manually, I guess this was deployed recently and we need to wait for a harvest.

michamos commented 1 year ago

When was this deployed? https://inspirehep.net/holdingpen/5828266 from yesterday doesn't have ORCIDs, although they are present in the XML file.

drjova commented 1 year ago

@michamos my bad, it's not deployed. Sorry for the false alarm