cern-sis / issues-inspire

0 stars 0 forks source link

fix snapshot tests #364

Closed karolina-siemieniuk-morawska closed 7 months ago

karolina-siemieniuk-morawska commented 1 year ago

There is no docker image available for ARM64 architecture with cypress and chrome/firefox, due to this we are not able to generate the same environment for snaphot testing on CI as locally. Good solution for this could be moving visual regression testing from e2e test suite and create an obligatory step in pre commit to run the snapshot tests locally before pushing anything to UI.

karolina-siemieniuk-morawska commented 11 months ago

Currently some snapshot tests are working on electron after using web hosted fonts instead system fonts. Still there are some snapshots that fail due to differences in sorting and number of contributions in jobs and institutions between local and CI. The reason fro this is yet unknown. In the future, if we don't fix it, we can consider switching from image snapshots to DOM snapshots like in https://www.cypress.io/blog/2018/01/16/end-to-end-snapshot-testing

karolina-siemieniuk-morawska commented 7 months ago

Will be continued in: https://github.com/cern-sis/issues-inspire/issues/447