search

cern-sis / issues-inspire

0 stars 0 forks source link

don't strip `authors.ids` from search API #426

Closed michamos closed 3 months ago

michamos commented 7 months ago

Heath reports in https://inspirehep.zulipchat.com/#narrow/stream/195298-experts/topic/API.3A.20ORCID.20does.20show.20fir.20first.20author.20in.20.22authors.22.20element/near/406175822 that the search API response for a given record doesn't contain authors.ids while the underlying record does: https://inspirehep.net/api/literature/2730489.

drjova commented 5 months ago

We have to check https://github.com/inspirehep/inspirehep/blob/3619b73dc7b84e6a749f80b7b66dd79a0697849a/backend/inspirehep/records/marshmallow/literature/common/author.py#L62-L82

PascalEgn commented 5 months ago

Can't reproduce the Issue as search API response for a given record returns an empty search.

@michamos do you have another example to reproduce the problem?

michamos commented 5 months ago

@PascalEgn not empty for me, could you try again?

PascalEgn commented 5 months ago

Tech notes:

Problem only seems to occur with records that are not in the INSPIRE Literature collection.

Add unit tests to further understand the behavior and debug this function.

drjova commented 4 months ago

@michamos deployed