cern-sis / issues-inspire

0 stars 0 forks source link

book chapters (with `publication_info.parent_record` field) are incorrectly displayed #445

Closed michamos closed 1 month ago

michamos commented 4 months ago

A user reports the following issue.

Consider the following example:

recid:2610328 On the origin of stellar energy Lev Davidovich Landau 1937 2 pages Part of Собрание трудов [Sobranie trudov]. Vol. 1, 333-334 Published in: Nature 141 (1938) 3564, 333-334, Compt.Rend.Acad.Sci.URSS 17 (1937) 6, 305-306, Dokl.Akad.Nauk SSSR 17 (1937) 6, 301-302 Published: Feb 19, 1938 and Published: 1937 and Published: 1965 in Oxford by Pergamon Press and Published: 1969 in Moscow by Наука [Nauka] DOI: 10.1038/141333b0, 10.1016/b978-0-08-010586-4.50032-8

The string:

{"year":1965,"page_end":"186","page_start":"185","parent_isbn":"9780080105864","parent_record":{"$ref":"https://inspirehep.net/api/literature/2610294"},"curated_relation":true}, {"year":1969,"page_end":"226","page_start":"224","parent_record":{"$ref":"https://inspirehep.net/api/literature/2730766"},"curated_relation":true}

contained in:

https://inspirehep.net/api/literature/2610328

is not correctly dislayed in:

https://inspirehep.net/literature/2610328

The following 2 errors occur: The piece

{"year":1965,"page_end":"186","page_start":"185","parent_isbn":"9780080105864","parent_record":{"$ref":"https://inspirehep.net/api/literature/2610294"},"curated_relation":true},

is not displayed at all in https://inspirehep.net/literature/2610328.

The second piece

{"year":1969,"page_end":"226","page_start":"224","parent_record":{"$ref":"https://inspirehep.net/api/literature/2730766"},"curated_relation":true}

is displayed with the wrong page numbers (333-334 instead of 224-226; the page numbers 333-334 belong to the Nature entry of the record).

This should be remedied.

karolina-siemieniuk-morawska commented 4 months ago

TECH NOTES:

  1. linked_book field should be renamed to linked_books and include all the publications that have parent_record field, not just the first one
  2. Apart from title and source fields it should also have page_start and page_end fields