Closed MJedr closed 1 year ago
- docker-compose - there's a local version, a production version inside of the docke-compose dir, also there's a file
production.yml
. We need to decide which one we want to use. Also, do we need all the services, eg. celerybeat, traefik? Also, local dockerfile it starts some not necessarily needed containers as flower.
We can go as light as possible, hence we can drop the prod compose as we will have a different configuration on prod and we will not reuse it.
- production requirements (also, do we need to keep requirements.txt when using poetry? It might be hard to maintain, or
we can use the same pre-commit hook as on inspirehep) We can just use poetry.
- do we need node config - we'll setup frontend separately
Do you mean the webpack?
- do we need the pre-commit hook https://github.com/SCOAP3/scoap3/blob/f6b4ed0bc6e736510b3f65562f5f926a57444fba/.pre-commit-config.yaml#L12-L16
hmm I would leave it, it will be helpful for the future. WDYT?
- we don't need such a detailed dependabot
Yes we can just leave the basic updates, not the docker and production.
Cookiecutter generated some files that we don't need. They include:
production.yml
. We need to decide which one we want to use. Also, do we need all the services, eg. celerybeat, traefik? Also, local dockerfile it starts some not necessarily needed containers as flower.