Configure ESLint and Prettier - Githubissues

cern-sis / react-formule

User-friendly, extensible form builder for React based on JSON Schema and RJSF

https://cern-sis.github.io/react-formule/

MIT License

10 stars 4 forks source link

Configure ESLint and Prettier #12

Closed miguelgrc closed 8 months ago

miguelgrc commented 9 months ago

We don't have prettier configured. We should make it so that files are formatted on save and on commit with a pre-commit hook. I'd go with option 1 here. Read also this. You might need a .prettierignore file as well.

Regarding ESLint, there are some things missing:

Adding plugin:react/recommended to the extends
Making sure it works with prettier side by side by adding https://github.com/prettier/eslint-config-prettier as well
We don't use react-fast-refresh anymore, so you can remove the dependency and all the related config in .eslintrc.cjs

Let me know if you need help

miguelgrc commented 8 months ago

Closed by #14