cerndb / dist-keras

Distributed Deep Learning, with a focus on distributed training, using Keras and Apache Spark.

http://joerihermans.com/work/distributed-keras/

GNU General Public License v3.0

624 stars 169 forks source link

Useless lines in mnist example #14

Closed edmondja closed 7 years ago

edmondja commented 7 years ago

In mnist.py example at the line 187 there are three useless lines (

Keras expects DenseVectors.

dense_transformer = DenseTransformer(input_col="features_normalized", output_col="features_normalized_dense") dataset_train = dense_transformer.transform(dataset_train) dataset_test = dense_transformer.transform(dataset_test) ) as "matrix" is already defined and as "features_normalized_dense" is unused.

mnist.py.zip

JoeriHermans commented 7 years ago

Could you please put the relevant line edits in the commits? Now you're just merging the development branch into the master branch.

JoeriHermans commented 7 years ago

As the author doesn't respond to my feedback, I'm closing this PR.