cerndb / dist-keras

Distributed Deep Learning, with a focus on distributed training, using Keras and Apache Spark.
http://joerihermans.com/work/distributed-keras/
GNU General Public License v3.0
623 stars 169 forks source link

unexpected keyword argument 'learning_rate' in DOWNPOUR #76

Open reedv opened 6 years ago

reedv commented 6 years ago

In the workflow example (https://github.com/cerndb/dist-keras/blob/master/examples/workflow.ipynb), getting error

---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)
<ipython-input-35-6528dd0e0d40> in <module>()
      1 trainer = DOWNPOUR(keras_model=model, worker_optimizer=optimizer, loss=loss, num_workers=num_workers,
      2                    batch_size=32, communication_window=5, learning_rate=0.05, num_epoch=1,
----> 3                    features_col="features_normalized", label_col="label")
      4 trainer.set_parallelism_factor(1)
      5 trained_model = trainer.train(training_set)

TypeError: __init__() got an unexpected keyword argument 'learning_rate'
anishsharma commented 6 years ago

Looks like a bug for me. Their is no learning_rate parameter in init () for DOWNPOUR.

reedv commented 6 years ago

@anishsharma That's interesting, since it does appear in the docstring for the class, https://github.com/cerndb/dist-keras/blob/master/distkeras/trainers.py#L715. Wonder if this is something that was removed or is a TODO item (though this repo appears dead).