cerndb / zkpolicy

Zookeeper Policy Audit Tool (aka zkPolicy) for checking and enforcing ACLs on ZNodes.
MIT License
7 stars 1 forks source link

Allow not declaring 'negate' in check definitions #3

Closed nbarrientos closed 11 months ago

nbarrientos commented 1 year ago

To fix #2, either zkpolicy allows check declarations without negate keys or the documentation (more specifically audit_example.yaml) needs fixing. My lucky guess is the former, so here's a patch.

Note to self: Lombok needs bumping to build the project with OpenJDK17.

@@ -64,8 +64,8 @@ or submit itself to any jurisdiction.
     <maven.compiler.source>1.8</maven.compiler.source>
     <maven.compiler.target>1.8</maven.compiler.target>
     <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-    <lombok.version>1.18.12</lombok.version>
-    <lombok.maven.plugin.version>1.18.12.0</lombok.maven.plugin.version>
+    <lombok.version>1.18.22</lombok.version>
+    <lombok.maven.plugin.version>1.18.20.0</lombok.maven.plugin.version>
     <picocli.version>4.5.0</picocli.version>
   </properties>
   <dependencies>

Closes #2.

NikolayTsvetkov commented 1 year ago

This PR is looking good :)

tr0k commented 11 months ago

Looks good, thanks Nacho and as discussed offline it makes sense. I am merging this.