search

cernekee / ics-openconnect

Android UI for OpenConnect VPN client
GNU General Public License v2.0
358 stars 130 forks source link

android_csd.sh doesn't find curl on Android 7.0 Nougat #20

Open fleminra opened 7 years ago

fleminra commented 7 years ago

I and my colleagues couldn't get OpenConnect to establish the VPN connection unless we changed "curl" to /system/bin/curl in android_csd.sh. Maybe instead of hardcoding that path as we did, that script could add /system/bin to the search path, to keep compatibility with devices that might store "curl" elsewhere.

cernekee commented 6 years ago

I found that on an Oreo device, the locally bundled curl binary would not execute because it has TEXTRELs. My proposed fix: https://github.com/cernekee/openconnect/commit/3c4622523a164f74e5f8f23782e2fa586a2e2c24

fleminra commented 6 years ago

I'm on an Oreo device now (Sony Xperia XZ1) and didn't run into the TEXTREL issue, but I did have to make that same android_csd.sh change that I mentioned before.