cerner / beadledom

A simple, composable framework for building RESTful services
http://engineering.cerner.com/beadledom
Apache License 2.0
25 stars 30 forks source link

Guice-based Beadledom clients use the wrong time unit for timeouts #144

Closed johnlcox closed 5 years ago

johnlcox commented 5 years ago

The BeadlecomClientBuilderProvider class configures the client timeouts using the provided configuration with the wrong time unit. The configuration contains values in milliseconds, but the provider is setting values as seconds. This means if the timeout is configured for 10000 milliseconds, the resulting timeout will be 10000 seconds instead of 10 seconds.

See: https://github.com/cerner/beadledom/blob/c40fba49a602b8e4639b7e334889ac5980cc5c75/client/beadledom-client-guice/src/main/java/com/cerner/beadledom/client/BeadledomClientBuilderProvider.java#L75-L77

johnlcox commented 5 years ago

Fixed by #147.