search

cerner / beadledom

A simple, composable framework for building RESTful services
http://engineering.cerner.com/beadledom
Apache License 2.0
25 stars 30 forks source link

Remove swagger1 module #168

Closed CalebBassham closed 4 years ago

CalebBassham commented 4 years ago

What was changed? Why is this necessary?

Removed the swagger1 module. Updated avro/swagger to work with swagger 1.5.

How was it tested?

./mvnw clean install -U

Closes #161

johnlcox commented 4 years ago

It would be good to start a 4.0 migration guide file similar to https://github.com/cerner/beadledom/blob/master/docs/source/releases/Beadledom30.rst

CalebBassham commented 4 years ago

It would be good to start a 4.0 migration guide file similar to https://github.com/cerner/beadledom/blob/master/docs/source/releases/Beadledom30.rst

Started in #169

CalebBassham commented 4 years ago

Should the swagger2 module, as in our second implementation of swagger-core, be renamed to just swagger since it could be confused with using swagger-core 2 when we are on swagger-core 1.5?

johnlcox commented 4 years ago

Should the swagger2 module, as in our second implementation of swagger-core, be renamed to just swagger since it could be confused with using swagger-core 2 when we are on swagger-core 1.5?

My thought is to keep it named swagger2 because 2 is the version number of the Swagger spec we are targeting. I think swagger-core has done a poor job with their versioning choices and it makes things confusing but the spec version is what matters most in my opinion.