search

cerner / cerner_kafka

A Kafka Cookbook for Chef
Apache License 2.0
30 stars 25 forks source link

#14: Removed default kafka configs #15

Closed bbaugher closed 8 years ago

mkwhitacre commented 9 years ago

+1 to the changes but might warrant a version bump since consumers will need to update more than their config to consume.

bbaugher commented 9 years ago

Are you thinking 2.0.0?

mkwhitacre commented 9 years ago

Not sure. The fact that upgrading to this version would result in their server.properties no longer being generated the same and seems like potentially surprising behavior (and could result in unexpected data loss since stuff like retention policy would be decreased)

So yeah am thinking that 2.0 might be a reasonable jump.

bbaugher commented 9 years ago

Bumped to 2.0.0

bbaugher commented 9 years ago

Updated README about server properties defaults, https://github.com/cerner/cerner_kafka/commit/47f8d37b2d05b8cf5db76ebc1ff25f2381f97111

noslowerdna commented 9 years ago

+1

mkwhitacre commented 9 years ago

+1

bbaugher commented 8 years ago

Got enough +1s, merging