cerner / cerner_kafka

A Kafka Cookbook for Chef
Apache License 2.0
30 stars 25 forks source link

Add kafka service stdout and stderr #6

Closed pradeepbhadani closed 9 years ago

pradeepbhadani commented 9 years ago

We tried this cookbook on our small VM(less than 4GB) which were failing silently due to default memory size issue and could not figure why they were failing. My Solution was redirecting kafka service output to a specific file So I could debug issue. Having the two attributes helps to mitigate situation like this in future . I created the recipe outside the default to check the status of Zookeeper as Kafka require Zookeeper to be in running state.

pradeepbhadani commented 9 years ago

I made the required changes.

bbaugher commented 9 years ago

This looks good thanks!

bbaugher commented 9 years ago

@pradeepbhadani do you mind opening a pull request to add yourself as a contributor.

pradeepbhadani commented 9 years ago

@bbaugher sure i will do. should create pull request from my old fork (which 8month old) or update my fork (to latest master of this repo) and send pull request?

bbaugher commented 9 years ago

Whichever is easier for you. I would think either would work if you only change the contributors?