cerner / terra-consumer

Consumer reusable components

http://engineering.cerner.com/terra-consumer

Apache License 2.0

10 stars 11 forks source link

Opened sub navigations get closed after page refresh #100

Open kafkahw opened 6 years ago

kafkahw commented 6 years ago

Issue Description

Issue Type

[ ] New Feature
[x] Enhancement
[ ] Bug
[ ] Other

Expected Behavior

Opened sub navigations should stay open after page refresh.

Current Behavior

Opened sub navigations get closed after page refresh.

Environment

Component Version: terra-consumer-nav@0.2.8
Browser Name and Version: Any browsers
Operating System and version (desktop or mobile): desktop and mobile

kafkahw commented 6 years ago

nov-16-2017 14-49-31

kafkahw commented 6 years ago

Looks like this can be addressed at consumer's level. Here's an example: https://github.cerner.com/HealtheLife/healthelastic-react/pull/96

alex-bezek commented 6 years ago

Can you describe the solution rather than linking an internal repo to our public github? Is this something we should fix at the component level instead of a 1 off fix? Was the issue that we were just using react router's activeClass for styling, but we need to set isActive to keep the sub navigation open? Is it even do-able at this components level, or does the owner of the router need to handle this like you are in your app?

mhemesath commented 6 years ago

Can we close this? It seems to me the consuming app should manage the state such that the menu is expanded....