React 15.5 upgrade - Githubissues

cerner / terra-core

Terra offers a set of configurable React components designed to help build scalable and modular application UIs. This UI library was created to solve real-world issues in projects we work on day to day.

http://terra-ui.com

Apache License 2.0

183 stars 165 forks source link

React 15.5 upgrade #203

Closed Matt-Butler closed 7 years ago

Matt-Butler commented 7 years ago

The react 15.5 release was non-passive for our packages. React is currently locked to version 15.4.2

We need to update our packages to be compatible with react 15.5.

https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html

Limitations:

[x] oliviertassinari/babel-plugin-transform-react-remove-prop-types#87
[x] ReactTraining/react-router#4932
[x] airbnb/enzyme#875
[x] reactjs/react-docgen#171
[x] yannickcr/eslint-plugin-react#1144
[x] https://github.com/Hacker0x01/react-datepicker/issues/813
[x] yahoo/react-intl#922
[x] reactjs/react-docgen#174
[x] davidtheclark/focus-trap-react#12
[x] https://github.com/tajo/react-portal/pull/144
[x] https://github.com/yahoo/react-intl/pull/940

Matt-Butler commented 7 years ago

I started some of the 15.5.x upgrade here: https://github.com/cerner/terra-core/tree/react-15.5

I updated each package to use the prop-types package.
We still need to update to react 15.5 after our 3rd party issues are resolved.

bjankord commented 7 years ago

Looks like the enzyme PR to add compat with react 15.5 has been merged. Waiting on a release for that.

bjankord commented 7 years ago

Pull request for react-docgen is still open: https://github.com/reactjs/react-docgen/pull/172

Matt-Butler commented 7 years ago

The react-docgen issue has been closed

Matt-Butler commented 7 years ago

react-datepicker merged their fix

ryanthemanuel commented 7 years ago

They released a version of react-docgen (2.14.1) to fix the build issues we were seeing around their compiling changes (https://github.com/reactjs/react-docgen/issues/174). I believe that this should allow us to push to the appropriate version of react-docgen.

bjankord commented 7 years ago

The react-intl pr for adding react 15.5 compat has been merged. This should be our last blocker for us on adding react 15.5 compat to our components.

Matt-Butler commented 7 years ago

Releases to support 15.5 / 16

[x] babel-plugin-transform-react-remove-prop-types - https://github.com/oliviertassinari/babel-plugin-transform-react-remove-prop-types/releases/tag/v0.4.1
[x] react-intl - https://github.com/yahoo/react-intl/pull/940 - https://github.com/yahoo/react-intl/releases/tag/v2.3.0
[x] react-router - https://github.com/ReactTraining/react-router/releases/tag/v3.0.4
[x] react-docgen - https://github.com/reactjs/react-docgen/releases/tag/v2.15.0
[x] enzyme - https://github.com/airbnb/enzyme/releases/tag/v2.8.1
[x] react-datepicker - https://github.com/Hacker0x01/react-datepicker/releases/tag/v0.46.0
[x] focus-trap-react - https://github.com/davidtheclark/focus-trap-react/releases/tag/3.0.3
[x] react-portal - https://github.com/tajo/react-portal/releases/tag/v3.1.0

Matt-Butler commented 7 years ago

https://www.npmjs.com/package/react-addons-test-utils ^ This has also been deprecated.

To get our jest tests working again, we need to also install react-test-renderer. https://github.com/airbnb/enzyme/issues/875#issuecomment-296450234

Matt-Butler commented 7 years ago

I updated the react-datepicker dependency to 0.46. In this version, they added a new prop called disableDateAutoCorrection.

MichaelDeBoey commented 7 years ago

react-intl v2.3.0 is released 🙂

Matt-Butler commented 7 years ago

After updating react-intl to 2.3.0, all of our tests now pass.

When running the site locally, I am still seeing this warning:

Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

I will investigate which dependency is still causing this warning.

Matt-Butler commented 7 years ago

After going through this exercise, I think it might be a good idea to separate out each of our components into their own webpack bundle.

It would test the component in isolation guaranteeing that css isn't leaking from one component to another.
It would be easier to isolate an issue down to a single component.

Matt-Butler commented 7 years ago

I had missed a couple proptypes. This branch is ready to upgrade to react-15.5: https://github.com/cerner/terra-core/tree/react-15.5

There are no longer warnings and all tests are passing.

Matt-Butler commented 7 years ago

After terra-time-input was merged into master, my tests are failing again. This is the issue:

[ ] https://github.com/text-mask/text-mask/issues/510

I can't merge the pull request until that issue is resolved.

^ We have removed text-mask for now. Closing this issue.