[terra-collapsible-menu-view] Removes dialog role for menu and sets aria-haspopup - Githubissues

cerner / terra-framework

Terra framework houses composed and higher order react components to help developers quickly build out new applications.

http://terra-ui.com

Apache License 2.0

67 stars 71 forks source link

[terra-collapsible-menu-view] Removes dialog role for menu and sets aria-haspopup #2127

Closed sugan2416 closed 6 months ago

sugan2416 commented 7 months ago

Summary

What was changed:

Sets aria-haspopup to boolean values
Removed dialog role terra-menu

Why it was changed:

aria-haspopup was set to dialog, changed to boolean.
Dialog role causes axe a11y failure being an inappropriate role.

Testing

This change was tested using:

[ ] WDIO
[ ] Jest
[ ] Visual testing (please attach a screenshot or recording)
[ ] Other (please describe below)
[x] No tests are needed

Reviews

In addition to engineering reviews, this PR needs:

[ ] UX review
[ ] Accessibility review
[ ] Functional review

Additional Details

This PR resolves:

UXPLATFORM-10322

Thank you for contributing to Terra. @cerner/terra