Replace comparing logic with itemkey.
Ignore if it is a negative left position value
Why it was changed:
This issues are reported when the screen is at 400%.
-- Alignment of menu items is not correct when the more button dropdown is opened.
Menu popup is not completely visible, as the half of the menu overlay is getting clipped off from the viewport.
-- De-selection of Tab.
Tab gets deselected on pressing space. And if user tries to navigate with TAB/SHIFT+TAB key then the focus doesn't go to the "More" dropdown.
Testing
This change was tested using:
[ ] WDIO
[ ] Jest
[ ] Visual testing (please attach a screenshot or recording)
[ ] Other (please describe below)
[x] No tests are needed
Reviews
In addition to engineering reviews, this PR needs:
[ ] UX review
[ ] Accessibility review
[x] Functional review
Additional Details
This PR resolves:
UXPLATFORM-10370
Thank you for contributing to Terra.
@cerner/terra
Summary
What was changed:
Replace comparing logic with itemkey. Ignore if it is a negative left position value
Why it was changed:
This issues are reported when the screen is at 400%.
-- Alignment of menu items is not correct when the more button dropdown is opened. Menu popup is not completely visible, as the half of the menu overlay is getting clipped off from the viewport. -- De-selection of Tab. Tab gets deselected on pressing space. And if user tries to navigate with TAB/SHIFT+TAB key then the focus doesn't go to the "More" dropdown.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-10370
Thank you for contributing to Terra. @cerner/terra