cerner / terra-graphs

A lightweight, JavaScript visualization API built using D3. Includes a vanilla javascript and react implementation.
Apache License 2.0
7 stars 6 forks source link

Update index js #334

Closed sdadn closed 6 months ago

sdadn commented 7 months ago

Summary

This PR continues the work in https://github.com/cerner/terra-graphs/pull/332 by updating index.js to also import the css. Now, css no longer has to be explicitly imported when consuming graphs.

Before:

import Carbon from '@cerner/carbon-graphs';
import '@cerner/carbon-graphs/dist/css/carbon-graphs.css';

After

import Carbon from '@cerner/carbon-graphs';

Testing

This change was tested using:

This was tested by ensuring there are no css changes in screenshots. Removing the css import causes the css to break, which confirms that this change works.

Reviews

In addition to engineering reviews, this PR needs:

Additional Details


Thank you for contributing to Terra. @cerner/terra

github-actions[bot] commented 7 months ago
Fails
:no_entry_sign: Please include a CHANGELOG entry for each changed package this PR. Looks like a CHANGELOG entry is missing for: - carbon-graphs - terra-graphs-docs

Generated by :no_entry_sign: dangerJS against 0d3cd775990705109c6d55faa55963d1a899fc85