Closed artpark closed 11 months ago
Fails | |
---|---|
:no_entry_sign: | Please include a CHANGELOG entry for each changed package on this PR. Looks like a CHANGELOG entry is missing for: - jest-config-terra - package-json-lint - terra-aggregate-translations - terra-open-source-scripts - webpack-config-terra |
Generated by :no_entry_sign: dangerJS against 925cbdf9d96325a8518742c315ed2a39f57c24ed
Fails 🚫 Please include a CHANGELOG entry for each changed package on this PR. Looks like a CHANGELOG entry is missing for:
- jest-config-terra
- package-json-lint
- terra-aggregate-translations
- terra-open-source-scripts
- webpack-config-terra
Since these files' changes are just lint fixes, I'm not going to write a CHANGELOG entry for them
Summary
What was changed:
Added quotations around the pathname to treat the whole path like one string in
packages/terra-functional-testing/src/services/wdio-selenium-docker-service.js
A bunch of eslint fixes too.
Why it was changed:
When running wdio tests, if the pathname to the target directory includes a whitespace, e.g.
.../Whitespace Folder/terra-framework/
, it would error at the docker compose step.Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-XXXX
Thank you for contributing to Terra. @cerner/terra