cerner / terra-toolkit

Terra Toolkit is a monorepo that contains utility modules for use when developing using Terra components
https://engineering.cerner.com/terra-toolkit
Apache License 2.0
32 stars 37 forks source link

Fixed package-json-lint bug and updated eslint-config-terra devDependencies #824

Closed sdadn closed 10 months ago

sdadn commented 10 months ago

Summary

This PR has the following changes:

Testing

This change was tested using:

This was tested by:

  1. Running npm install -D lerna@6 at the root of the package
  2. Running npx lerna run --parallel clean:install at the root level. This will cause the dependencies to be installed at the package level for each package.
  3. Running npx lerna run --parallel compile.
  4. Running npx lerna run --parallel lint. This will test the linter dependency updates by running the linter at the package level.

The result should be something like this:

CleanShot 2023-08-30 at 15 04 30

Reviews

In addition to engineering reviews, this PR needs:


Thank you for contributing to Terra. @cerner/terra

github-actions[bot] commented 10 months ago
Fails
:no_entry_sign: Please include a CHANGELOG entry for each changed package on this PR. Looks like a CHANGELOG entry is missing for: - browserslist-config-terra - duplicate-package-checker-webpack-plugin - jest-config-terra - package-json-lint-config-terra - stylelint-config-terra - terra-aggregate-translations - terra-cli - terra-enzyme-intl - terra-open-source-scripts - terra-toolkit-docs - webpack-config-terra

Generated by :no_entry_sign: dangerJS against 49cc842f1c8da674f8813c2714cb15b9f61e2316

sdadn commented 10 months ago

Fails 🚫 Please include a CHANGELOG entry for each changed package on this PR. Looks like a CHANGELOG entry is missing for:

  • browserslist-config-terra
  • duplicate-package-checker-webpack-plugin
  • jest-config-terra
  • package-json-lint-config-terra
  • stylelint-config-terra
  • terra-aggregate-translations
  • terra-cli
  • terra-enzyme-intl
  • terra-open-source-scripts
  • terra-toolkit-docs
  • webpack-config-terra

Generated by 🚫 dangerJS against 500cdbb

These changes do not need to be released

adoroshk commented 10 months ago

Installed lerna, run clean:install, compile and lint commands, which successfully worked.

Clean:install

Screenshot 2023-08-31 at 9 41 15 AM

Compile

Screenshot 2023-08-31 at 9 41 03 AM

Lint

Screenshot 2023-08-31 at 9 38 45 AM