Closed sdadn closed 10 months ago
Fails | |
---|---|
:no_entry_sign: | Please include a CHANGELOG entry for each changed package on this PR. Looks like a CHANGELOG entry is missing for: - browserslist-config-terra - duplicate-package-checker-webpack-plugin - jest-config-terra - package-json-lint-config-terra - stylelint-config-terra - terra-aggregate-translations - terra-cli - terra-enzyme-intl - terra-open-source-scripts - terra-toolkit-docs - webpack-config-terra |
Generated by :no_entry_sign: dangerJS against 49cc842f1c8da674f8813c2714cb15b9f61e2316
Fails 🚫 Please include a CHANGELOG entry for each changed package on this PR. Looks like a CHANGELOG entry is missing for:
- browserslist-config-terra
- duplicate-package-checker-webpack-plugin
- jest-config-terra
- package-json-lint-config-terra
- stylelint-config-terra
- terra-aggregate-translations
- terra-cli
- terra-enzyme-intl
- terra-open-source-scripts
- terra-toolkit-docs
- webpack-config-terra
These changes do not need to be released
Installed lerna, run clean:install, compile and lint commands, which successfully worked.
Summary
This PR has the following changes:
package-json-lint
.eslint-config-terrra
andjest-config-terra
devDependency format from^x.y.z
tox
. Both of these formats are identical, this was changed so that changes to these packages do not cause minor version bumps in other terra-toolkit packages and unnecessary releases like in #823 .eslint-plugin-formatjs
to2.19.1
as the latest 2.x version has a peerDependency ofeslint@8
which conflicts with theeslint-config-terra
peerDependency ofeslint@7
.Testing
This change was tested using:
This was tested by:
npm install -D lerna@6
at the root of the packagenpx lerna run --parallel clean:install
at the root level. This will cause the dependencies to be installed at the package level for each package.npx lerna run --parallel compile
.npx lerna run --parallel lint
. This will test the linter dependency updates by running the linter at the package level.The result should be something like this:
Reviews
In addition to engineering reviews, this PR needs:
Thank you for contributing to Terra. @cerner/terra