cerner / terra-toolkit

Terra Toolkit is a monorepo that contains utility modules for use when developing using Terra components
https://engineering.cerner.com/terra-toolkit
Apache License 2.0
32 stars 37 forks source link

[duplicate-package-checker-webpack-plugin] Support node 16+ #828

Open peitschie opened 9 months ago

peitschie commented 9 months ago

Bug Report

Use of this package with modern versions of node shows a warning:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '@cerner/duplicate-package-checker-webpack-plugin@2.5.0',
npm WARN EBADENGINE   required: { node: '10 || 12 || 14', npm: '6 || 9' },
npm WARN EBADENGINE   current: { node: 'v18.17.1', npm: '9.6.7' }
npm WARN EBADENGINE }

This issue was originally reported and fixed in https://github.com/cerner/terra-toolkit/issues/730

The fix was then reverted in https://github.com/cerner/terra-toolkit/pull/814/files#diff-a36d0892a0a105b7e516b0e4964a180398c75d5e5c7e98cdc4a2604f90515611

I'm using node 18 + NPM 9.6.7, which seems to work just fine despite the warning.

tradeshift-larsbojensen commented 9 months ago

Agree with the above. I can't install a package that depends on the duplicate-package-checker-webpack-plugin:

npm ERR! code EBADENGINE
npm ERR! engine Unsupported engine
npm ERR! engine Not compatible with your version of node/npm: @cerner/duplicate-package-checker-webpack-plugin@2.6.0
npm ERR! notsup Not compatible with your version of node/npm: @cerner/duplicate-package-checker-webpack-plugin@2.6.0
npm ERR! notsup Required: {"node":"10 || 12 || 14","npm":"6 || 9"}
npm ERR! notsup Actual:   {"npm":"9.8.1","node":"v18.18.0"}
josundt commented 8 months ago

I also request that you please support current Node/NPM versions. The package now only works if you use outdated Node versions!

Not sure why these node and npm version restrictions were added to package.json in version 2.4.0 of the package, because the 2.3.0 package version has worked and still works just fine with Node LTS (currently version 18.18.0).

I can no longer upgrade after version 2.3.0; please fix.

stale[bot] commented 6 months ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed in seven days if no further activity occurs. Thank you for your contributions.

peitschie commented 6 months ago

... Still active.

Philipp91 commented 5 months ago

Would it be enough to just drop the restriction from package.json?

stale[bot] commented 3 months ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed in seven days if no further activity occurs. Thank you for your contributions.

josundt commented 3 months ago

If this package is still supposed to be maintained, please fix. If not, please mark it as deprecated on npm.

DarkMikey commented 2 months ago

Still relevant!