cerner / terra-toolkit

Terra Toolkit is a monorepo that contains utility modules for use when developing using Terra components
https://engineering.cerner.com/terra-toolkit
Apache License 2.0
32 stars 37 forks source link

[terra-functional-testing] Fixing Nexus screenshot bugs #839

Closed BenBoersma closed 5 months ago

BenBoersma commented 6 months ago

Summary

Fixed Nexus upload/download of screenshots for multiple nodes. Fixed PR commenting when mismatch was detected. Fixed logging for when doing a PR build or Screenshot Branch commit build not showing which tests had mismatches. **What was changed:** Nexus screenshots are now stored as multiple directories for each node being run. Directories are named as following with undefined values not being present '$THEME-$LOCALE-$BROWSER-$FORMFACTOR$' I.E 'terra-default-theme-en-chrome-large' PR commenting is now based on the existence of a file that is made during `toMatchReference` calls instead of via process.env variables. This file is deleted on test suite completion. Validates.screenshot now passes in the test name to its 'toMatchReference' calls, so that when 'toMatchReference' is doing Nexus mismatch logic it can now output a log message of the test that fails due to mismatch so that in can be found by Nexus users. **Why it was changed:** ### Testing

This change was tested using:

Reviews

In addition to engineering reviews, this PR needs:

Additional Details

This PR resolves:

UXPLATFORM-9299


Thank you for contributing to Terra. @cerner/terra