cerner / terra-toolkit

Terra Toolkit is a monorepo that contains utility modules for use when developing using Terra components
https://engineering.cerner.com/terra-toolkit
Apache License 2.0
32 stars 37 forks source link

Added missing fibers transient dependency #843

Closed sdadn closed 4 months ago

sdadn commented 4 months ago

Summary

What was changed: This PR adds the missing fibers dependency which is a transient dependency of webpack-config-terra through sass-loader@10.

Why it was changed: Currently, the fibers dependency was installed through @wdio/sync in terra-functional-testing, causing an indirect dependency on that terra-functional-testing regardless of it is needed. Therefore, fibers was explicitly added to webpack-config-terra to decouple that link and to allow for removing of @wdio/sync for a future webdriverio upgrade.

Testing

This change was tested using:

This was tested by ensuring that the local dev-site works with npm start.

Reviews

In addition to engineering reviews, this PR needs:

Additional Details


Thank you for contributing to Terra. @cerner/terra

sdadn commented 4 months ago

All the tests are passing locally; the test failure is unrelated to this change.

CleanShot 2024-02-06 at 16 52 45