cerner / terra-toolkit

Terra Toolkit is a monorepo that contains utility modules for use when developing using Terra components
https://engineering.cerner.com/terra-toolkit
Apache License 2.0
32 stars 37 forks source link

[terra-functional-testing] Add flag to disable internal webpack server #849

Closed sdadn closed 3 months ago

sdadn commented 4 months ago

Summary

This PR adds the --disable-server flag to the terra-functional-testing wdio command to disable the internal webapck server for local development. This will allow developers to use another webpack service, such as from npm start which can help speed up development if that is already running.

Testing

This change was tested using:

This was tested by installing a local copy of terra-functional-testing with these changes in terra-framework, running npm start in a terminal and running wdio tests with the --disable-server flag in another server. The wdio service managed to connect to the external webpack server and tests were able to run successfully.

CleanShot 2024-03-06 at 14 18 30

CleanShot 2024-03-06 at 14 23 57

Reviews

In addition to engineering reviews, this PR needs:

Additional Details


Thank you for contributing to Terra. @cerner/terra

kenk2 commented 3 months ago

I'm noticing that quite a few of the CLI params are being changed. How will this affect consumers downstream?

sdadn commented 3 months ago

I'm noticing that quite a few of the CLI params are being changed. How will this affect consumers downstream?

This is mainly updating the documentation as kebab case is the convention for cli params. This won't affect consumers as the cli accepts both kebab case and camel case for parameters.