cerner / terra-toolkit

Terra Toolkit is a monorepo that contains utility modules for use when developing using Terra components
https://engineering.cerner.com/terra-toolkit
Apache License 2.0
32 stars 37 forks source link

[terra-functional-testing] update logger output for the `--disable-server` flag #852

Closed sdadn closed 3 months ago

sdadn commented 3 months ago

Summary

This PR corrects the logger output for the target ip address when the --disable-server flag is used.

Before:

CleanShot 2024-03-08 at 14 51 10

After: CleanShot 2024-03-08 at 14 56 26

This will now display the correct ip address for debugging purposes.

Testing

This change was tested using:

This was tested by installing a local copy in terra-framework and running the wdio test, resulting in the screenshots above.

Reviews

In addition to engineering reviews, this PR needs:

Additional Details


Thank you for contributing to Terra. @cerner/terra

github-actions[bot] commented 3 months ago
Fails
:no_entry_sign: Please include a CHANGELOG entry for each changed package on this PR. Looks like a CHANGELOG entry is missing for: - terra-functional-testing

Generated by :no_entry_sign: dangerJS against b628982507c0d660592c55428726bbe72c02533c

sdadn commented 3 months ago

Fails 🚫 Please include a CHANGELOG entry for each changed package on this PR. Looks like a CHANGELOG entry is missing for:

  • terra-functional-testing

Generated by 🚫 dangerJS against b628982

This is a niche fix for an unreleased change, I don't think it warrants a CHANGELOG entry.