cernopendata / cernopendata-client

CERN Open Data command-line client
http://cernopendata-client.readthedocs.io/
GNU General Public License v3.0
10 stars 9 forks source link

installation: pin xrootd package #121

Closed tiborsimko closed 3 years ago

tiborsimko commented 3 years ago

Pins xrootd to 4.12.2 that is known to work well for compiling latest stable xrotdpyfs. The later versions lead to v- version detection troubles.

tiborsimko commented 3 years ago

Note: this fixes the installation problem, but also one can see some runtime warnings:

$ cernopendata-client download-files --recid 5000 --protocol xrootd
==> Downloading file 1 of 1
Plugin No such file or directory loading sec.protocol libXrdSecgsi-4.so
Plugin No such file or directory loading sec.protocol libXrdSecsss-4.so
  -> File: ./5000/2011-doubleelectron-doublemu-mueg-ttbar-1.0.0.tar.gz
==> Success!

Considering the file size chunking troubles and #120 I think we'll prioritise switching from xrootdpyfs to vanilla xrootd soon :wink:

codecov-io commented 3 years ago

Codecov Report

Merging #121 (8a032a6) into master (3b74b0f) will decrease coverage by 8.28%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
- Coverage   86.83%   78.55%   -8.29%     
==========================================
  Files          11       11              
  Lines         676      676              
==========================================
- Hits          587      531      -56     
- Misses         89      145      +56     
Impacted Files Coverage Δ
cernopendata_client/walker.py 25.00% <0.00%> (-66.67%) :arrow_down:
cernopendata_client/downloader.py 58.11% <0.00%> (-10.48%) :arrow_down:
cernopendata_client/cli.py 94.44% <0.00%> (-2.47%) :arrow_down: