cernopendata / opendata.cern.ch

Source code for the CERN Open Data portal
http://opendata.cern.ch/
GNU General Public License v2.0
666 stars 148 forks source link

templates: check all links #2072

Closed tiborsimko closed 6 years ago

tiborsimko commented 6 years ago

Check all COD2 links whether they are well alive on COD3 and whether they return something reasonable. This should have been already addressed, but we've seen some recurse, so let's double check all redirections once more.

Rules of thumb:

(1) If we clearly know where to redirect and the target page is a single page, then we should always redirect there.

(bad because it returns more items than it should)

(2) If it is not clear where to redirect, for example because the concept is hidden (such as collection pages, education vs research), then redirect to appropriate search page with appropriately selected data type facets.

(bad because it exposes past concepts over the new ones)

(3) If we redirect to a search page, but there is no good combination of facets that would permit us to expose "new concepts" over the "old concepts", then let us use the past concepts:

(albeit ideally we should prefer option 2 over option 3)

(4) Here is the list of all pages to check:

atrisovic commented 6 years ago

Many of these links are broken (eg /resources and /research). Should we have new views for them?

ioannistsanaktsidis commented 6 years ago

hmmm I don't know what happen with them. /resources /research used to work .

tiborsimko commented 6 years ago

/research redirects well to a long query:

which gives an empty page.

This was working before, so it must be connected to ES2 -> ES5 upgrade. CC @annatrz

tiborsimko commented 6 years ago

BTW here is the reason why my original rule of thumb 1 good approach (=redirecting to given target page) is better the bad approach (=redirecting to search):

g

Please make sure to tick the URLs in the above list only after it's fully working and follows the rule of thumb...

ioannistsanaktsidis commented 6 years ago

Closing as already addressed.