cernopendata / opendata.cern.ch

Source code for the CERN Open Data portal
http://opendata.cern.ch/
GNU General Public License v2.0
656 stars 147 forks source link

search: unnecessary paginator #3083

Closed tiborsimko closed 9 months ago

tiborsimko commented 3 years ago

Current behavioun

When a search returns low numbers of results, such as 3, we are still showing the pagination element:

search-pages

This is not necessary.

Expected behaviour

ParthS007 commented 3 years ago

While investigating, there are two different components Pagination and ResultsPerPage which shows the pagination bar in the bottom and X result per page respectively. The issue requires to access one prop of ResultsPerPage component i.e currentSize just outside the Pagination. Tried with state hook and passing of currentQueryState but no success so far.

psaiz commented 9 months ago

This is a tricky one. I am not convinced that the user experience is improved by removing the pagination filters. I've briefly discussed this with our invenio colleagues, and they don't like the idea of removing it.

In my opinion, this one needs more discussion before proceeding to implement anything

psaiz commented 9 months ago

For the time being, let's stay with the default behaviour from indico.