search

cerpus / Edlib

Edlib is an application for creating, sharing, storing and using rich interactive learning resources.
https://docs.edlib.com
GNU General Public License v3.0
40 stars 7 forks source link

Make newly added H5P content types work with "Max Score" #1367

Open tmkarlsen opened 1 year ago

tmkarlsen commented 1 year ago

Make newly added H5P content types work with "Max Score".

The following H5P types is still not returning score:

https://github.com/cerpus/Edlib/commit/f6b9c784b8e9b3389cb05d420aeba3278a4f4d87

chrieinv commented 1 year ago

I've verified that they emit a 'score' xAPI message after the Check button is clicked. The H5P.SortParagraphs emits two score messages, the first is correct. In the last message 'score_max' and 'score_raw' are null, and as a result 'score' is NaN (null / null).

Since the crossword layout is not fixed, it's generated when the user views the resource, the max score value can only be calculated by Edlib if 'Score words' is checked.

chrieinv commented 1 year ago

@tmkarlsen Could you provide more info? Where is it not returning score and how do I reproduce the behavior?

tmkarlsen commented 1 year ago
  1. Go to edstep/gamilab-test
  2. Find a shared resource of the three different kinds
  3. Edit and see under preferences that no Max score is displayed
  4. Insert into context and verify that no score i set.
chrieinv commented 1 year ago

Could be that the presave script is not copied to the library folder https://docs.edlib.com/docs/developers/thirdPartyContent/h5p/max-score/writing#adding-the-script-to-the-library