Bulk update error messages (prod and test)

cerpus / Edlib

Edlib is an application for creating, sharing, storing and using rich interactive learning resources.

https://docs.edlib.com

GNU General Public License v3.0

40 stars 7 forks source link

Bulk update error messages (prod and test) #2652

Open tmkarlsen opened 8 months ago

tmkarlsen commented 8 months ago

Bulk update fails for drag and drop When trying to bulk update H5P.DragQuestion 1.13.15, all content fails with on of the two error messages below

Request URL: https://ca.h5p-test.ndla.no/content/upgrade/library?library=/H5P.DragQuestion/1/14

Error messages An error occurred while processing parameters: Cannot read properties of undefined (reading 'task')

An error occurred while processing parameters: dropzone.correctElements.filter is not a function

Screenshots

Skjermbilde 2024-01-04 kl 13 18 25

Skjermbilde 2024-01-04 kl 12 24 44

chrieinv commented 8 months ago

Looks like you are upgrading to 1.14, but which patch version?

tmkarlsen commented 8 months ago

I'm trying to update to 1.14.15 Skjermbilde 2024-01-04 kl 13 18 25

chrieinv commented 8 months ago

Looking at the upgrades script it seems like all errors are due to issues with the content.

The ones with reading 'task' error don't have any questions defined
The correct elements should be set as an array. The dropzone.correctElements.filter is not a function error occurs if it's not an array

These issues could be corrected in the upgrade script or a checks could be added to prevent errors. In previous upgrades, like the one to 1.13, the code checks if 'questions' exists before trying to access it, this is not done in the 1.14 upgrade.