cerpus / Edlib

Edlib is an application for creating, sharing, storing and using rich interactive learning resources.
https://docs.edlib.com
GNU General Public License v3.0
40 stars 7 forks source link

New copy/variant does not list it as separate content #2697

Open tmkarlsen opened 5 months ago

tmkarlsen commented 5 months ago

Creating a new variant/copy should make a separate piece of content As of now, the copy/new variant is listed as part of the version history in detail view https://hub.edlibdev.net/content/01hsdn2qd0m2c0hfajtrazj31a

To Reproduce

  1. Create a H5P content and save it
  2. Edit it and tick off "New variant" in the language section (changing language should not be necessary )
  3. Save it.
  4. Verify that a new content has been registered in ca-admin
  5. Observe that the same amount of content is listed under "My content" and that the original content has been overwritten with what should have been the new copy of it.

Expected behavior New content should be added to "my content" and should follow the version structure, as seen backend in CA-admin. ( new content should not be listed as a version in the version history for the original content)

Screenshots Skjermbilde 2024-03-20 kl  11 28 07

Skjermbilde 2024-03-20 kl  11 28 16

tmkarlsen commented 2 months ago

A new test shows that the copy is separated backend (ca-admin), but the hub combines the two into one version and only shows the last version: No changes were made to the new copy on save, I only ticked off "Make new variant".

Image

Image

emmachughes commented 2 months ago

The 'make variant' toggle has no effect in Edlib 3. As discussed previously, it is to be removed in favour of making copies on the hub side.